ABI checker fixes part 2 #1459
Open
ABI checker fixes part 2 #1459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because `nlink_t` and `blksize_t` had incorrect sizes, the struct was incorrectly defined.
avdgrinten
reviewed
Sep 26, 2025
| struct msqid64_ds { | ||
| struct ipc64_perm msg_perm; | ||
| #if (UINTPTR_MAX == UINT64_MAX) /* || x32 ABI */ | ||
| #if (__INTPTR_WIDTH__ == 64) /* || x32 ABI */ |
There was a problem hiding this comment.
iirc the header of these macros was not included, but that did not throw warnings so the check was silently broken.
Comment on lines
59
to
63
| pid_t shm_cpid; | ||
| pid_t shm_lpid; | ||
| unsigned long shm_nattch; | ||
| unsigned long __unused[3]; | ||
| time_t shm_atime; | ||
| time_t shm_dtime; | ||
| time_t shm_ctime; | ||
| unsigned long __unused[2]; | ||
| }; |
There was a problem hiding this comment.
This does not match glibc/musl. In particular, removing shm_{a,d,c}time without replacement will most likely break downstream programs.
There was a problem hiding this comment.
Fixed in the fixup commit - the layout already matches what glibc exposes, only changing the names was necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.