-
Notifications
You must be signed in to change notification settings - Fork 31
Typescript #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Typescript #31
Conversation
|
@YovelNehmady : Is this ready for review? |
|
@maniac-tech: Yes. |
|
@YovelNehmady can you also create a PR in the example application consuming these changes ? This way we can test, and update the sample application too. |
|
@maniac-tech Yes I can. |
Lets do that then |
I am from Israel and we are currently at war so it will take me a little time to do this. |
Take your time, and most importantly be safe @YovelNehmady ! |
|
@maniac-tech would you like me to complete this? Having typescript would be very helpful while working on the frontend. |
Sure! |
Description
In this PR I changed the JS files to TS files and added type to make this lib more easy to use.
Fixes # (issue)
#29 #
Type of change