Skip to content

Conversation

cocox
Copy link

@cocox cocox commented Oct 3, 2011

No description provided.

@cocox
Copy link
Author

cocox commented Oct 3, 2011

Also corrected bug http://leetcode.net/mantis/view.php?id=104

@cocox
Copy link
Author

cocox commented Oct 3, 2011

@davidhicks
Copy link
Member

@davidhicks
Copy link
Member

This patch also seems to require the user to specify (and read) minutes as float values (3.5 hours = 3 hours 30 minutes, 0.25 hours = 15 minutes) which seems confusing.

My patch from 2 years ago at http://git.mantisforge.org/w/timecard/dhx.git?a=commitdiff;h=93c6829f48b62aace54d79ad1a81b7e507ff8d7d (there are other related patches in that branch too) used "hh:mm" notation which is the same as what the inbuilt MantisBT time tracking feature uses.

I think the reason these patches weren't merged 2 years ago is that John didn't like the idea of allowing fractional hours to be tracked (too precise). Therefore the patch mentioned above allows the administrator to toggle the precision between hours and minutes.

These old patches would need some work to bring them up to a standard ready to commit to the current Timecard plugin (and some changes to make the plugin work with the 'master' branch). However I think they serve as a good reference when creating a new/updated patch to handle minute resolutions.

@cocox
Copy link
Author

cocox commented Oct 4, 2011

Yes, your right, perhaps it is a bit confiusing.

I did it this way because where i work we use other systems this way. We need it in the same way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants