NAVAND-960: allow different PredictiveCacheLocationOptions for different zooms #6868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChangelogFeatures
Bug fixes and improvements
Known issues
|
korshaknn
reviewed
Jan 26, 2023
libnavigation-base/src/main/java/com/mapbox/navigation/base/options/PredictiveCacheOptions.kt
Show resolved
Hide resolved
...n-base/src/test/java/com/mapbox/navigation/base/options/PredictiveCacheOptionsBuilderTest.kt
Outdated
Show resolved
Hide resolved
Comment on lines
-20
to
23
| internal val mapsPredictiveCacheLocationOptions = | ||
| mutableMapOf<Any, Triple<TilesetDescriptor, TileStore, PredictiveCacheLocationOptions>>() | ||
| internal val mapsPredictiveCacheLocationOptions = mutableMapOf<Any, | ||
| Pair<TileStore, List<Pair<TilesetDescriptor, PredictiveCacheLocationOptions>>>>() | ||
| internal val mapsPredictiveCacheLocationOptionsTileVariant = | ||
| mutableMapOf<Any, MutableMap<String, Pair<TileStore, PredictiveCacheLocationOptions>>>() |
There was a problem hiding this comment.
I'm thinking if we need to store TileStore here at all.
We use it to recreate controllers, but TileStore should be the same instance across all calls createMapsController. We can save it as a PredictiveCache::tileStore on initial call and use for recreations
There was a problem hiding this comment.
Should it? As far as I understand, for different MapboxMaps there can be different TIleStores. That's how we obtain TileStore:
val tileStore = map.getResourceOptions().tileStore
There was a problem hiding this comment.
tileStore instance should be built on a customer side and the instance should be passed to Maps, NN, Search, so all SDKs will work with the same offline folder
val tileStore = TileStore.create(context.provideTileStorePath())
according to the docs
Creates a TileStore instance for the given storage path. The returned instance exists as long as it is retained by the client. If the tile store instance already exists for the given path this method will return it without creating a new instance, thus making sure that there is only one tile store instance for a path at a time. If the given path is empty, the tile store at the default location is returned.
that's why I think we shouldn't store it for each MapboxMap
There was a problem hiding this comment.
But can't the user use different paths for different MapboxMaps?
There was a problem hiding this comment.
I don't know, all I'm saying is that it's possible, so should we artificially remove this possibility? Especially considering the fact that it was possible previously.
There was a problem hiding this comment.
Anyway, I think we can follow-up separately as this PR did not change this behaviour, right?
Codecov Report
@@ Coverage Diff @@
## main #6868 +/- ##
============================================
- Coverage 72.85% 72.76% -0.10%
+ Complexity 5657 5579 -78
============================================
Files 786 783 -3
Lines 30434 30192 -242
Branches 3607 3570 -37
============================================
- Hits 22172 21968 -204
+ Misses 6831 6798 -33
+ Partials 1431 1426 -5
|
LukasPaczos
approved these changes
Feb 1, 2023
libnavigation-base/src/main/java/com/mapbox/navigation/base/options/PredictiveCacheOptions.kt
Outdated
Show resolved
Hide resolved
libnavigation-base/src/main/java/com/mapbox/navigation/base/options/PredictiveCacheOptions.kt
Outdated
Show resolved
Hide resolved
libnavigation-base/src/main/java/com/mapbox/navigation/base/options/PredictiveCacheOptions.kt
Outdated
Show resolved
Hide resolved
korshaknn
approved these changes
Feb 2, 2023
dzinad
force-pushed
the
NAVAND-960-dd
branch
2 times, most recently
from
4f70849 to
97b2840
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.