-
Notifications
You must be signed in to change notification settings - Fork 320
NAVAND-1108: test that reproduces the issue #6869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAVAND-1108: test that reproduces the issue #6869
Conversation
ChangelogFeatures
val shielded = roadName.shielded into: val shielded = roadComponent.shield != null
Bug fixes and improvements
Known issues
|
Codecov Report
@@ Coverage Diff @@
## main #6869 +/- ##
=========================================
Coverage 72.68% 72.68%
Complexity 5572 5572
=========================================
Files 782 782
Lines 30166 30166
Branches 3562 3562
=========================================
Hits 21926 21926
Misses 6814 6814
Partials 1426 1426
|
.upcomingRoadObjects | ||
.first { it.roadObject.id == incidentId } | ||
|
||
assertEquals( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we expect them to be equal?
The routes are different, do they have the same geometry (at least until the incident)? If yes, it should be specified in the comments. If the geometry is different, distanceToStart
may be different (it's distance along the route, not direct distance, right?).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we expect them to be equal?
Current location doesn't change and both routers heads to the same direction thought the same incident.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If yes, it should be specified in the comments.
Thank you for the feedback. I will try to improve readability of the test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dzinad , I updated the test. Do you understand what and why it checks now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the waypoint is strictly on the route's geometry? Could you mention it somewhere in the comment?
No description provided.