Skip to content

Conversation

SevaZhukov
Copy link

Failure release-snapshot job confuses the team when it runs on branches and PRs without the publish-snapshot label.

I propose a way like for the mobile-metrics-benchmarks job. If you want to publish a snapshot just approve the release-snapshot-start job, and it will start the release-snapshot-1 job (with postfix 1 because we use this job for the main and release branches too). The release-snapshot-2 job will be started without approvals for the main and release branches.

image

@RingerJK @Zayankovsky

@SevaZhukov SevaZhukov added the skip changelog Should not be added into version changelog. label Jan 26, 2023
@github-actions
Copy link

Changelog

Features

  • Added RoadComponent.language value. #6833
  • ⚠️ Changed EHorizonEdgeMetadata.names class from RoadName to RoadComponent. #6833
    To migrate change your code from:
val shielded = roadName.shielded

into:

val shielded = roadComponent.shield != null
  • Added support for continuous EV alternatives in NavigationRouteAlternativesObserver. #6833
  • Fixed issues with map-matching to HOV-only roads. #6833
  • Set a limit of simultaneously running onboard route requests to avoid too many tasks blocking too much of the device's computing resources. #6833
  • Fixed an issue with Road Access Policy ignoring the setting to map-match to closed road sections, when enabled. #6833
  • Added MapboxTripStarter to simplify the solution for managing the trip session and replaying routes. This also makes it possible to share the replay state between drop-in-ui and android-auto. #6794

Bug fixes and improvements

  • Increased max distance from the user indicator to route line valid to continue vanishing updates from 3m to 10m. #6854
  • Fixed an issue where alternative routes might have had an incorrect or incomplete portion of the route refreshed or occasionally fail to refresh. #6848
  • Removed NavigationRoute#hasUnexpectedClosures and added RouteProgress#hasUnexpectedUpcomingClosures instead that checks whether route has upcoming unexpected closures (the algorithm does not take into account closures that the puck has already been on) #6841
  • Improved NavigationView camera behavior to go back into overview state if routes change during route preview state. #6840
  • Improved NavigationView camera behavior to ignore keyboard insets. #6845

Known issues ⚠️

Other changes

Android Auto Changelog

Features

  • Added support for Junction Views. #6849

Bug fixes and improvements

  • Optimized SpeedLimitWidget memory usage. #6859

@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #6874 (31f736e) into main (09b5248) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #6874   +/-   ##
=========================================
  Coverage     72.68%   72.68%           
  Complexity     5572     5572           
=========================================
  Files           782      782           
  Lines         30166    30166           
  Branches       3562     3562           
=========================================
  Hits          21926    21926           
  Misses         6814     6814           
  Partials       1426     1426           

@SevaZhukov
Copy link
Author

Also, I've added the GitHub action which runs the release-snapshot job on every commit if you set the label publish-snapshot

Copy link
Contributor

@RingerJK RingerJK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

- release-snapshot:
requires:
- release-snapshot-start
- release-snapshot:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you have 2 jobs with the same name?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one job. We run it by:

  • main and release branches
  • approval in circle ci
  • set PR label

@SevaZhukov SevaZhukov merged commit 047ca54 into main Jan 27, 2023
@SevaZhukov SevaZhukov deleted the NAVSDK-846 branch January 27, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
publish-snapshot skip changelog Should not be added into version changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants