-
Notifications
You must be signed in to change notification settings - Fork 320
Release snapshot workflow refactoring #6874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ChangelogFeatures
val shielded = roadName.shielded into: val shielded = roadComponent.shield != null
Bug fixes and improvements
Known issues
|
Codecov Report
@@ Coverage Diff @@
## main #6874 +/- ##
=========================================
Coverage 72.68% 72.68%
Complexity 5572 5572
=========================================
Files 782 782
Lines 30166 30166
Branches 3562 3562
=========================================
Hits 21926 21926
Misses 6814 6814
Partials 1426 1426 |
Also, I've added the GitHub action which runs the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
- release-snapshot: | ||
requires: | ||
- release-snapshot-start | ||
- release-snapshot: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you have 2 jobs with the same name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is one job. We run it by:
- main and release branches
- approval in circle ci
- set PR label
Failure release-snapshot job confuses the team when it runs on branches and PRs without the
publish-snapshot
label.I propose a way like for the mobile-metrics-benchmarks job. If you want to publish a snapshot just approve the
release-snapshot-start
job, and it will start therelease-snapshot-1
job (with postfix 1 because we use this job for the main and release branches too). Therelease-snapshot-2
job will be started without approvals for the main and release branches.@RingerJK @Zayankovsky