feat: adds support for group get all roles endpoint #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardenchant
force-pushed
the
feature/get-all-roles-for-group
branch
from
4da8a04 to
3306cfb
Compare
ryshoooo
reviewed
May 25, 2025
There was a problem hiding this comment.
Hi @hardenchant
Thanks a lot! Looks OK, but I can't really say whether this works or not without unit tests. Could we add those in as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no tests right now, but this PR give you ability to request all bindings (clients and realm) for a group with one request, just like keycloak do it in the admin panel.