Remove tree-sitter-vue #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I chose this version of Node because: - Latest LTS stability: It's the most recent Long Term Support version, providing stability and security updates until April 2026, making it ideal for production use. - Maximum compatibility: It's the highest Node.js version that works seamlessly with all existing project dependencies without requiring any dependency upgrades. Update Node.js & NPM to 22.17.0
Since highlight.js 11.6+, the `distributed` keyword is built-in and no custom overrides are needed
Replace wrapper.find with wrapper.findComponent instead since wrapper.find is deprecated
contains is deprecated and will be removed in the next major version. Use `wrapper.find`, `wrapper.findComponent` or `wrapper.get` instead
This change fixes the deprecation warning: [Vue warn]: Duplicate keys detected: 'A'. This may cause an update error.
3 tasks
tree-sitter-vue [1] is not compatible with Node.js 22. This is because it uses tree-sitter [2] v0.19.x, which does not support Node.js 22. The version of tree-sitter that works with Node.js 22 is v0.21.0 or later, as it uses the new Node-API [3] instead of NAN [4] for its Node bindings. Since tree-sitter-vue hasn't been updated to use v0.21.0+, it doesn't work with Node.js 22. There is no official grammar for Vue that uses tree-sitter v0.21+ and Node-API yet. [1] https://github.com/ikatyang/tree-sitter-vue [2] https://github.com/tree-sitter/tree-sitter [3] https://nodejs.github.io/node-addon-examples/about/what/ [4] https://github.com/nodejs/nan
marinaaisa
force-pushed
the
remove-tree-sitter-vue
branch
from
7e96c3e to
d801157
Compare
marinaaisa
force-pushed
the
update-node
branch
from
bd2ee89 to
3acc738
Compare
marinaaisa
force-pushed
the
update-node
branch
4 times, most recently
from
1c5f528 to
a4ce39a
Compare
marinaaisa
force-pushed
the
update-node
branch
from
a4ce39a to
529ae65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #156714814, if applicable:
Summary
tree-sitter-vue [1] is not compatible with Node.js 22. This is because
it uses tree-sitter [2] v0.19.x, which does not support Node.js 22.
The version of tree-sitter that works with Node.js 22 is v0.21.0 or
later, as it uses the new Node-API [3] instead of NAN [4] for its Node
bindings.
Since tree-sitter-vue hasn't been updated to use v0.21.0+, it doesn't
work with Node.js 22.
There is no official grammar for Vue that uses tree-sitter v0.21+ and
Node-API yet.
[1] https://github.com/ikatyang/tree-sitter-vue
[2] https://github.com/tree-sitter/tree-sitter
[3] https://nodejs.github.io/node-addon-examples/about/what/
[4] https://github.com/nodejs/nan
Dependencies
swiftlang#952
Testing
Steps:
npm installnpm run docsChecklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
npm test, and it succeeded