Improve routes order #13
Open
+24
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to split the routes into fallbackRoutes and pageRoutes to have more flexibility into how to organize the routes in our app.
The order for our routes should be:
- page routes
- localized page routes
- fallback routes
This is important because otherwise the request for localized routes
will fall into the fallback routes.
Before, the routes were:
[
{
"path": "/tutorials/:id",
"name": "tutorials-overview"
},
{
"path": "/tutorials/:id/*",
"name": "topic"
},
{
"path": "/documentation*",
"name": "documentation-topic"
},
{
"path": "*",
"name": "not-found",
"component": {...}
},
{
"path": "*",
"name": "server-error",
"component": {...}
},
{
"path": "/:locale?/tutorials/:id",
"name": "tutorials-overview-locale"
},
{
"path": "/:locale?/tutorials/:id/*",
"name": "topic-locale"
},
{
"path": "/:locale?/documentation*",
"name": "documentation-topic-locale"
}
]
Now they are:
[
{
"path": "/tutorials/:id",
"name": "tutorials-overview"
},
{
"path": "/tutorials/:id/*",
"name": "topic"
},
{
"path": "/documentation*",
"name": "documentation-topic"
},
{
"path": "/:locale?/tutorials/:id",
"name": "tutorials-overview-locale"
},
{
"path": "/:locale?/tutorials/:id/*",
"name": "topic-locale"
},
{
"path": "/:locale?/documentation*",
"name": "documentation-topic-locale"
},
{
"path": "*",
"name": "not-found",
"component": {...}
},
{
"path": "*",
"name": "server-error",
"component": {...}
}
]
Pages like Not Found or Server error pages should also be localized, so
we need to add them into the router's paths.
Before, the routes were:
[
{
"path": "/tutorials/:id",
"name": "tutorials-overview"
},
{
"path": "/tutorials/:id/*",
"name": "topic"
},
{
"path": "/documentation*",
"name": "documentation-topic"
},
{
"path": "/:locale?/tutorials/:id",
"name": "tutorials-overview-locale"
},
{
"path": "/:locale?/tutorials/:id/*",
"name": "topic-locale"
},
{
"path": "/:locale?/documentation*",
"name": "documentation-topic-locale"
},
{
"path": "*",
"name": "not-found",
"component": {...}
},
{
"path": "*",
"name": "server-error",
"component": {...}
}
]
Now they are:
[
{
"path": "/tutorials/:id",
"name": "tutorials-overview"
},
{
"path": "/tutorials/:id/*",
"name": "topic"
},
{
"path": "/documentation*",
"name": "documentation-topic"
},
{
"path": "/:locale?/tutorials/:id",
"name": "tutorials-overview-locale"
},
{
"path": "/:locale?/tutorials/:id/*",
"name": "topic-locale"
},
{
"path": "/:locale?/documentation*",
"name": "documentation-topic-locale"
},
{
"path": "/:locale?/*",
"name": "not-found-locale",
"component": {...}
},
{
"path": "/:locale?/*",
"name": "server-error-locale",
"component": {...}
},
{
"path": "*",
"name": "not-found",
"component": {...}
},
{
"path": "*",
"name": "server-error",
"component": {...}
}
]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #161830978, if applicable:
Summary
The order for our routes should be:
Before, the order was:
now it is:
Dependencies
swiftlang#970
Testing
Steps:
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
npm test, and it succeeded