This repository was archived by the owner on Jan 7, 2022. It is now read-only.
Emit an 'open' event when the popup is opened #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 21, 2021 17:24
…s in Spanish to end in periods. This results in the test passing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves issue #137 using the same approach as pull request #175. A README update and test is included.
To pass tests I had to update the default locale test in
DatetimeCalendar.spec.js. The test was rendering each weekday's name without a period ex.Lunbut it was expecting a periodLun.. I suspect this was due to changes outside of this project's scope. Hopefully this change isn't a problem.