- 
                Notifications
    
You must be signed in to change notification settings  - Fork 7
 
Feature/source scrapping #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            Pierre-Auguste-UL
  wants to merge
  23
  commits into
  marmelab:main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
theosli:feature/source_scrapping
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Open
            
            Feature/source scrapping #14
                    Pierre-Auguste-UL
  wants to merge
  23
  commits into
  marmelab:main
from
theosli:feature/source_scrapping
  
      
      
   
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    4ab6ede    to
    997c2db      
    Compare
  
    …/curator-ai into feature/source_scrapping
              
                    jonathanarnault
  
              
              requested changes
              
                  
                    Feb 7, 2025 
                  
              
              
            
            
        
          
                website/src/components/Features.tsx
              
                Outdated
          
        
      
      Comment on lines
    
      14
     to 
      17
    
  
  | const [subscriptionMessage, setSubscriptionMessage] = useState(''); | ||
| const [subscriptionError, setSubscriptionError] = useState(false); | ||
| const [emailMessage, setEmailMessage] = useState(''); | ||
| const [emailError, setEmailError] = useState(false); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit-pick: Can you merge this into a single state ?
You should probably use a form library for this BTW, e.g.: https://tanstack.com/form/latest
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Problem
A user wants to be able to modify their list of sources by adding a new one or removing an existing one.
Solution
A user should be able to reply to one of the curator's emails with simple instructions like “remove XXX” or “add YYY” to delete or add a source to their personalized list.
The service should recognize when the user refers only to the domain name of a source (e.g., “remove Hacker News” should remove https://news.ycombinator.com/).
For additions, if the user does not provide an RSS feed link, the service should search a database of sources for the associated RSS feed. If it cannot find one, it should respond by asking the user to provide an explicit RSS link.
For any new RSS feed, the service should determine a label that will help future users discover it (e.g., https://news.ycombinator.com/ → "Hacker News").
Finally, the service should confirm the success of the operation by sending an email to the user with their updated preferences.
How To Test
See how to test it.