Improve memory footprint of useCanAccess when it targets a record
#10828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
reviewed
Jul 4, 2025
Madeorsk
requested changes
Jul 7, 2025
There was a problem hiding this comment.
Great! Can you just add the React Query Debugger as @fzaninotto suggested?
Madeorsk
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When wrapping many different records in
<CanAccess>, its memory footpring is huge.Solution
This is because we pass the whole record in the
useQueryparameters. We can only pass the record identifier.How It Was Tested
Before the fix:
After the fix:
Even with this small use case (records are quite simple), that's 10MB saved.
Additional Checks
masterfor a bugfix or a documentation fix, ornextfor a feature