-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Add offline support to <ListBase>
and <List>
#10896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
isAuthPending && | ||
!disableAuthentication && | ||
loading !== undefined && | ||
loading !== false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before this change, the content was never shown when isAuthPending
was true. Now, it can be. I know we did the same with ShowBase
and EditBase
, but I wanted to be sure that it is done on purpose: if someone provided null
to hide the content while authentication is pending, it will now show the content instead of hiding it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually realize I introduced the same regression in EditBase
and ShowBase
... PR imcoming. Regarding your comment, you're right and that's what we decided with @fzaninotto. Might be worth to discuss it again before releasing.
Problem
Our components and hooks can't leverage the offline support provided by Tanstack Query.
Solution
ra-ui-materialui
How To Test
<ListBase>
<List>
Additional Checks
master
for a bugfix or a documentation fix, ornext
for a featureAlso, please make sure to read the contributing guidelines.