Skip to content

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Aug 26, 2025

Problem

Our components and hooks can't leverage the offline support provided by Tanstack Query.

Solution

  • Make sure our data loading hooks returns the data needed to detect those cases
  • Provide components, hooks and props allowing to handle offline scenarios
  • Provide default offline components in ra-ui-materialui

How To Test

Additional Checks

  • The PR targets master for a bugfix or a documentation fix, or next for a feature
  • The PR includes unit tests (if not possible, describe why)
  • The PR includes one or several stories (if not possible, describe why)
  • The documentation is up to date

Also, please make sure to read the contributing guidelines.

@djhi djhi added the RFR Ready For Review label Aug 26, 2025
Base automatically changed from offline-support-reference-array-input to next August 28, 2025 07:32
isAuthPending &&
!disableAuthentication &&
loading !== undefined &&
loading !== false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before this change, the content was never shown when isAuthPending was true. Now, it can be. I know we did the same with ShowBase and EditBase, but I wanted to be sure that it is done on purpose: if someone provided null to hide the content while authentication is pending, it will now show the content instead of hiding it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually realize I introduced the same regression in EditBase and ShowBase... PR imcoming. Regarding your comment, you're right and that's what we decided with @fzaninotto. Might be worth to discuss it again before releasing.

@Madeorsk Madeorsk added this to the 5.11.0 milestone Sep 1, 2025
@Madeorsk Madeorsk merged commit bad689e into next Sep 1, 2025
15 checks passed
@Madeorsk Madeorsk deleted the offline-support-list branch September 1, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Development

Successfully merging this pull request may close these issues.

2 participants