Skip to content

Remove unnecessary eslint-disable- comments for SLDS2 #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2025
Merged

Remove unnecessary eslint-disable- comments for SLDS2 #490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd31946
(Datepicker): remove unnecessary `eslint-disable-` comments
msmx-mnakagawa Jul 2, 2025
2938aa7
(Modal): remove an unnecessary `eslint-disable-` comment
msmx-mnakagawa Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/scripts/Datepicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,6 @@ const DatepickerDate: FC<DatepickerDateProps> = (props) => {
>
<span
className='slds-day'
// eslint-disable-next-line jsx-a11y/no-noninteractive-tabindex
tabIndex={selectable ? 0 : -1}
onClick={selectable ? onDateClick : undefined}
onKeyDown={selectable ? onDateKeyDown : undefined}
Expand Down Expand Up @@ -301,7 +300,6 @@ const DatepickerMonth = forwardRef(
<thead>
<tr>
{dayjs.weekdaysMin(true).map((wd, i) => (
// eslint-disable-next-line react/no-array-index-key
<th key={i}>
<abbr title={dayjs().weekday(i).format('ddd')}>{wd}</abbr>
</th>
Expand All @@ -310,7 +308,6 @@ const DatepickerMonth = forwardRef(
</thead>
<tbody>
{cal.weeks.map((days, i) => (
// eslint-disable-next-line react/no-array-index-key
<tr key={i}>
{days.map((date, dayIndex) => (
<DatepickerDate
Expand Down
2 changes: 1 addition & 1 deletion stories/Modal.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ export const FormElements: StoryObj<StoryProps> = {
.map((a, i) => (
<PicklistItem
value={i + 1}
label={`Item #${i + 1}`} // eslint-disable-next-line react/no-array-index-key
label={`Item #${i + 1}`}
key={i}
/>
))}
Expand Down