Skip to content

Show Picklist dividers expectedly #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 29, 2025
Merged

Show Picklist dividers expectedly #498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2b9f30
add a Story with dividers of `Picklist`
msmx-mnakagawa Sep 17, 2025
dc701e8
remove unnecessary classname for dividers
msmx-mnakagawa Sep 17, 2025
db5cb4b
Merge branch 'master' into support-slds-2-show-picklist-dividers-expe…
stomita Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/scripts/Picklist.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -694,12 +694,8 @@ export const PicklistItem: FC<PicklistItemProps> = ({
}
);

const listItemClassNames = classnames(
'slds-listbox__item',
divider ? `slds-has-divider_${divider}-space` : undefined
);
const mainListItem = (
<li role='presentation' className={listItemClassNames}>
<li role='presentation' className='slds-listbox__item'>
<div
id={value ? `${optionIdPrefix}-${value}` : undefined}
className={itemClassNames}
Expand Down
33 changes: 33 additions & 0 deletions stories/Picklist.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,3 +268,36 @@ export const WithTooltip: ComponentStoryObj<typeof Picklist> = {
},
},
};

/**
*
*/
export const WithDividers: ComponentStoryObj<typeof Picklist> = {
name: 'With Dividers',
args: {
label: 'Picklist Label',
defaultOpened: true,
children: [
<PicklistItem
key='1'
label='Picklist Item One'
value='1'
divider='bottom'
/>,
<PicklistItem key='2' label='Picklist Item Two' value='2' />,
<PicklistItem
key='3'
label='Picklist Item Three'
value='3'
divider='top'
/>,
],
},
parameters: {
docs: {
description: {
story: 'Picklist with dividers',
},
},
},
};