Skip to content

Update design_password_eye.xml #4827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

PowerPizza
Copy link

Fixed reversed behavior of this drawable with passwordToggleEnabled attribute of TextInputLayout of material design.
previously happens,
Eye close = password shows as text
Eye open = password shows as dot dot
NOW (fixed),
Eye close = password shows as dot dot
Eye open = password shows as text

Fixed reversed behavior of this drawable with passwordToggleEnabled attribute of TextInputLayout of material design.
previously,
Eye close = password shows as text
Eye open = password shows as dot dot
NOW (fixed),
Eye close = password shows as dot dot
Eye open = password shows as text
Copy link

google-cla bot commented Jun 22, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@hunterstich
Copy link
Contributor

Hi @PowerPizza. Thanks for the PR.

We've had this issue in the past - #1171 - where we discussed this with our design team and intentionally landed on using:

Eye open = passwords are obscured
Eye with slash = passwords show as clear text

Looking at the TextFieldOutlinedIconsDemoFragment.java in our catalog, I believe the current behavior is correct. My understanding is the design intent is the icon signals the action to invoke on click and not the current state of the text's visibility.

@hunterstich hunterstich closed this Jul 9, 2025
@PowerPizza
Copy link
Author

Ohh okay... It makes sense,
The icon should represent what will happen if the user clicks it
not what is currently happening.

@PowerPizza PowerPizza deleted the patch-1 branch July 11, 2025 06:22
@PowerPizza PowerPizza restored the patch-1 branch July 11, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants