[ButtonGroup] Implement height change animation in vertical MaterialButtonGroup #4893
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all, let me know if I should open an issue first for a pull request like this: I wrote on Mastodon with Liam Spradlin from the design team who helped designing the button groups behavior, my question was whether a vertical button group also should animate the height of the button neighbors like it animates the width in horizontal orientation:
I found no open or closed issue for that so I implemented it on my own, I hope it's all correct! Tests are green and the catalog button group animations are working now in vertical orientation like Liam said.