Skip to content

[ButtonGroup] Implement height change animation in vertical MaterialButtonGroup #4893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

patzly
Copy link
Contributor

@patzly patzly commented Aug 6, 2025

Hi all, let me know if I should open an issue first for a pull request like this: I wrote on Mastodon with Liam Spradlin from the design team who helped designing the button groups behavior, my question was whether a vertical button group also should animate the height of the button neighbors like it animates the width in horizontal orientation:

@iamliam Hi Liam, one specific question regarding button groups: in the next expressive update of my metronome app I would like to use vertical button groups of MDC Android with large icon buttons. The view library doesn't animate the height of the buttons on tap as it would animate the width in a horizontal button group and I think there aren't any specs for vertical button groups in the docs. Should the height also be animated or are vertical button groups generally not intended?

@patzly the height should be animated in both orientations, because the design intent is to affect the surrounding buttons on interaction. If it's not supported, I can pass that along to the team working on the library!

I found no open or closed issue for that so I implemented it on my own, I hope it's all correct! Tests are green and the catalog button group animations are working now in vertical orientation like Liam said.

@dsn5ft dsn5ft requested a review from pekingme August 6, 2025 14:27
@patzly
Copy link
Contributor Author

patzly commented Aug 18, 2025

@pekingme Just wanted to kindly ask if this might make it into the next alpha? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants