Skip to content

Conversation

@orionarcher
Copy link
Contributor

Summary

Major changes:

Add a coerce_formal_charges method to the pymatgen.io.openff code, allowing molecules with formal charges to be more accurately parsed.

Checklist

  • Google format doc strings added. Check with ruff.
  • Type annotations included. Check with mypy.
  • Tests added for new features/fixes.
  • If applicable, new classes/functions/modules have duecredit @due.dcite decorators to reference relevant papers by DOI (example)

@shyuep
Copy link
Member

shyuep commented Oct 29, 2024

Please add a unittest for the new method. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants