Skip to content

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Oct 16, 2025

This PR allows the TeX input jax's cleanAttributes() filter to work with nodes that don't have attributes (like XML nodes). Currently, it will crash with an error about not being able to call get() on an undefined value.

@dpvc dpvc requested a review from zorkow October 16, 2025 11:32
@dpvc dpvc added this to the v4.0.1 milestone Oct 16, 2025
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.66%. Comparing base (fe4921f) to head (8505432).
⚠️ Report is 19 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1368   +/-   ##
========================================
  Coverage    86.66%   86.66%           
========================================
  Files          338      338           
  Lines        84269    84270    +1     
  Branches      4784     4785    +1     
========================================
+ Hits         73032    73033    +1     
  Misses       11214    11214           
  Partials        23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit 791e311 into develop Oct 17, 2025
3 checks passed
@dpvc dpvc deleted the fix/cleanAttributes branch October 17, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants