Skip to content

Fix linting CI #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 29, 2021
Merged

Fix linting CI #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af041d7
Fix setup of linting GitHub Action.
QuLogic Jun 29, 2021
0a53b36
Fix flake8 errors in tests.
QuLogic Jun 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/reviewdog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
python-version: 3.8

- name: Install flake8
run: pip3 install -r flake8
run: pip3 install flake8

- name: Set up reviewdog
run: |
Expand All @@ -30,6 +30,6 @@ jobs:
REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
set -o pipefail
flake8 --docstring-convention=all | \
flake8 | \
reviewdog -f=pep8 -name=flake8 \
-tee -reporter=github-check -filter-mode nofilter
4 changes: 2 additions & 2 deletions test_cycler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@

if sys.version_info < (3,):
from itertools import izip as zip
range = xrange
str = unicode
range = xrange # noqa
str = unicode # noqa


def _cycler_helper(c, length, keys, values):
Expand Down