MessageDiff: generate proper regexes on message tail modification #1853
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes faulty logic generating bad regexes on message edits in a following case:
In a user sent out a message before finishing it, with an unfinished last word, like here:
how many wood would a woodchuck cand then edited it to
how many wood would a woodchuck chuck if a woodchuck would chuck wood,the bridge would output
s/c/chuck if a woodchuck would chuck wood/, which,if evaluated, produces
how many wood would a woodchuck if a woodchuck would chuck woodhuck chuck.The bridge did not take the possibility of the replaced part occurring more than one time into the account.
These changes fix it by introducing the regex dollar operator for matching line endings in this very specific case.