Skip to content

Fix the NDK_PATH value #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2025
Merged

Fix the NDK_PATH value #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33a9d4d
Set the NDK path before installing the Android SDK, as that will rese…
jmartinesp Jul 23, 2025
895e439
Add comment to remind us of this issue
jmartinesp Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/release_crypto.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,12 @@ jobs:
java-version: '17'
distribution: 'temurin' # See 'Supported distributions' for available options

- name: Install android sdk
uses: malinskiy/action-android/install-sdk@release/0.1.4

# Note: the install android SDK step resets the `ANDROID_HOME` variable to a new folder with an update SDK but no NDK,
# so we need to set this NDK_PATH before that happens
- name: Configure android ndk
run: |
NDK_PATH=$ANDROID_HOME/ndk/$NDK_VERSION
echo $NDK_PATH
if [ -d "$NDK_PATH" ]; then
echo "ANDROID_NDK_HOME=$NDK_PATH" >> $GITHUB_ENV
echo "Using ndk $NDK_PATH"
Expand All @@ -61,6 +61,9 @@ jobs:
exit 1
fi

- name: Install android sdk
uses: malinskiy/action-android/install-sdk@release/0.1.4

- name: Install Rust
uses: dtolnay/rust-toolchain@stable

Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/release_sdk_parallel.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,12 @@ jobs:
java-version: '17'
distribution: 'temurin' # See 'Supported distributions' for available options

- name: Install android sdk
uses: malinskiy/action-android/install-sdk@release/0.1.4

# Note: the install android SDK step resets the `ANDROID_HOME` variable to a new folder with an update SDK but no NDK,
# so we need to set this NDK_PATH before that happens
- name: Configure android ndk
run: |
NDK_PATH=$ANDROID_HOME/ndk/$NDK_VERSION
echo $NDK_PATH
if [ -d "$NDK_PATH" ]; then
echo "ANDROID_NDK_HOME=$NDK_PATH" >> $GITHUB_ENV
echo "Using ndk $NDK_PATH"
Expand All @@ -61,6 +61,9 @@ jobs:
exit 1
fi

- name: Install android sdk
uses: malinskiy/action-android/install-sdk@release/0.1.4

- name: Install Rust
uses: dtolnay/rust-toolchain@stable

Expand Down
Loading