Skip to content

allow building from source #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

allow building from source #36

wants to merge 2 commits into from

Conversation

selfisekai
Copy link

@selfisekai selfisekai commented Mar 22, 2024 •
edited
Loading

closes #35

@selfisekai selfisekai marked this pull request as draft March 22, 2024 20:02
Hywan
Hywan reviewed Mar 25, 2024
View reviewed changes
Copy link
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh neat! Thanks for the patch. Looks good so far. What does it need to get out of the draft?

@selfisekai
Copy link
Author

i haven't tested it as an npm release yet, just from git

@selfisekai selfisekai marked this pull request as ready for review March 25, 2024 11:05
@mqudsi
Copy link

mqudsi commented Jul 27, 2024 •
edited
Loading

It would be nice to have this as a default fallback when prebuilt binaries aren't available for the current platform/architecture, without npm install --build-from-source or env npm_config_build_from_source= yarn install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hywan Hywan Hywan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

allow building from source

3 participants

@selfisekai @mqudsi @Hywan