Add backup encryption function #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewFerr
reviewed
Jul 25, 2024
src/backup.rs
Outdated
| } | ||
|
|
||
| #[napi(strict)] | ||
| pub async fn encrypt(&self, exported_session_json: String) -> napi::Result<KeyBackupData> { |
There was a problem hiding this comment.
How does this json get retrieved?
There was a problem hiding this comment.
Ah, comes from export_room_keys_for_session. I should document that really!
Comment on lines
66
to
73
| Ok(KeyBackupData { | ||
| first_message_index: res.first_message_index.into(), | ||
| forwarded_count: res.forwarded_count.into(), | ||
| is_verified: res.is_verified, | ||
| session_data_ephemeral: res.session_data.ephemeral.to_string(), | ||
| session_data_ciphertext: res.session_data.ciphertext.to_string(), | ||
| session_data_mac: res.session_data.mac.to_string(), | ||
| }) |
There was a problem hiding this comment.
Will this response be used anywhere? If the job of this method is to encrypt the data, it seems odd to also return that data. Then again, it's returned by InnerMegolmV1BackupKey.encrypt, so it's a pattern we could repeat here.
AndrewFerr
approved these changes
Jul 26, 2024
|
This is held up on me writing a sufficient test case on the other side, fwiw. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still use olm in one place in Pipe to support encrypting room backups across different clients. This exposes the ability for us to run the encryption function via the Rust SDK instead which means we can stop using Olm entirely \o/