Add invalidate_group_session #47
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
requested changes
Aug 11, 2025
| /// Returns true if a session was invalidated, false if there was | ||
| /// no session to invalidate. | ||
| #[napi(strict)] | ||
| pub async fn invalidate_group_session(&self, room_id: &identifiers::RoomId) -> bool { |
There was a problem hiding this comment.
Is there a reason not to call this discard_room_key too, as it's much less confusing for developers following the rust-sdk.
There was a problem hiding this comment.
This is the same function name in the matrix-sdk-crypto-wasm repo
Refs: https://github.com/matrix-org/matrix-sdk-crypto-wasm/blob/main/src/machine.rs#L835
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to invalidate the currently active outbound group session for the given room.