Skip to content

Conversation

bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Aug 21, 2025

This adds a large integration test, that will exhaustively check all our notification modes, and how they relate to thread subscriptions:

  • for each interesting global notification behavior (all messages / mentions only),
  • for each interesting room notification behavior (all messages / mentions only / mute),

Look if a subscribed thread will trigger a mention or not.

There are a few false-negatives, which motivated matrix-org/matrix-spec-proposals@bd9e842 in the spec. This PR will make it possible to check that these cases have been fixed, after implementing the new behavior from that spec update.

Part of #5038.

Copy link

codspeed-hq bot commented Aug 21, 2025

CodSpeed Performance Report

Merging #5565 will not alter performance

Comparing bnjbvr/push-rules-exhaustive-testing (8b38d59) with main (25a8187)

Summary

✅ 37 untouched benchmarks

Copy link

codecov bot commented Aug 21, 2025

Codecov Report

❌ Patch coverage is 95.16129% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.65%. Comparing base (25a8187) to head (8b38d59).
⚠️ Report is 18 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/matrix-sdk/src/room/mod.rs 86.66% 2 Missing ⚠️
crates/matrix-sdk/src/test_utils/mocks/mod.rs 97.72% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5565   +/-   ##
=======================================
  Coverage   88.64%   88.65%           
=======================================
  Files         340      340           
  Lines       95065    95127   +62     
  Branches    95065    95127   +62     
=======================================
+ Hits        84273    84331   +58     
- Misses       6607     6610    +3     
- Partials     4185     4186    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bnjbvr bnjbvr force-pushed the bnjbvr/push-rules-exhaustive-testing branch from cf625b4 to 8b38d59 Compare August 21, 2025 13:37
@bnjbvr bnjbvr marked this pull request as ready for review August 21, 2025 13:37
@bnjbvr bnjbvr requested a review from a team as a code owner August 21, 2025 13:37
@bnjbvr bnjbvr requested review from stefanceriu and removed request for a team August 21, 2025 13:37
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, lgtm 👍

@bnjbvr bnjbvr merged commit 40d3dd5 into main Aug 25, 2025
58 of 59 checks passed
@bnjbvr bnjbvr deleted the bnjbvr/push-rules-exhaustive-testing branch August 25, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants