fix(search): Make adding events to index idempotent.

[dragonfly1033]

Adding events to the index is now idempotent.

• Public API changes documented in changelogs (optional)

Signed-off-by: Shrey Patel [email protected]

[codspeed-hq]

CodSpeed Performance Report

Merging #5567 will not alter performance

_{Comparing dragonfly1033/fix_indexing (59be73d) with main (8804966)}

Summary

✅ 37 untouched benchmarks

[codecov]

Codecov Report

❌ Patch coverage is 72.88136% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.62%. Comparing base (b6433de) to head (59be73d).
⚠️ Report is 20 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
crates/matrix-sdk-search/src/index.rs	72.88%	3 Missing and 13 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5567      +/-   ##
==========================================
- Coverage   88.63%   88.62%   -0.01%     
==========================================
  Files         341      341              
  Lines       95138    95196      +58     
  Branches    95138    95196      +58     
==========================================
+ Hits        84322    84371      +49     
+ Misses       6628     6625       -3     
- Partials     4188     4200      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bnjbvr]

Slightly worried that we have to run a specific search for what's conceptually a set lookup. Could you write a tiny benchmark and measure how long it takes to add the same document, say, 1000 / 10000 / 100000 times? (not necessarily one in the benches dir and that we'd check in, but you'd get bonus points for that!)

[bnjbvr]

Please look at my previous review comment where I asked for running a tiny benchmark.

[dragonfly1033]

Sorry, got a bit eager. Here's the results, looks like nothing to worry about.

For reference: this is benching the RoomIndex::handle_event function on the same event.