MSC2676: Message editing #2676
Merged
MSC2676: Message editing #2676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 7, 2020
uhoreg
added
kind:core
erdnaxeli
reviewed
Nov 21, 2020
Co-authored-by: Alexandre Morignot <[email protected]>
jplatte
reviewed
Nov 25, 2020
Sorunome
reviewed
Dec 31, 2020
CarlSchwan
reviewed
Jan 21, 2021
turt2live
added
the
needs-implementation
deepbluev7
added a commit
to Nheko-Reborn/mtxclient
that referenced
this pull request
Jun 9, 2021
t3chguy
reviewed
Jul 23, 2021
|
The final comment period, with a disposition to merge, as per the review above, is now complete. |
mscbot
added
finished-final-comment-period
and removed
disposition-merge
final-comment-period
turt2live
added
spec-pr-missing
turt2live
pushed a commit
that referenced
this pull request
Jul 18, 2022
* initial version of message editing proposal * fix MSC numbers * Fix JSON in example Co-authored-by: Alexandre Morignot <[email protected]> * clarifications * remove obsolete "XXX:", and fix a typo * Initial cleanup and restructuring * Clarify algorithm for replacing content * background * More clarifications on applying edits * Clarify behaviour of redactions * Minor grammar fixes * Move the section on `msgtype` down It clutters up the initial description - let's move it down into a more detailed section. * Clarify how edits are ordered - we use event_id as a tiebreaker. We also have a section in "Future considerations" about this, so I don't think we need the braindump in "Edge cases". * Spec the behaviour for encrypted events * Requirements for an edit event to be considered valid * Collect "client behaviour" and "sever behaviour" together ... and clarify these sections. * Clarify permalinks section * Notes on edits of replies * Clarify that `m.relates_to` within `m.new_content` is ignored * Clarifications from review * event ids are sorted lexicographically * Clarify aggregation section * minor clarifications * Clarify which endpoints support edits * move definition of latest edit * Apply suggestions from code review Co-authored-by: Hubert Chathi <[email protected]> * fix typo * Attempt to clarify encrypted events Co-authored-by: Alexandre Morignot <[email protected]> Co-authored-by: Richard van der Hoff <[email protected]> Co-authored-by: Richard van der Hoff <[email protected]>
|
Spec PR: matrix-org/matrix-spec#1211 |
richvdh
added
spec-pr-in-review
richvdh
added a commit
to matrix-org/matrix-spec
that referenced
this pull request
Sep 21, 2022
richvdh
added
merged
|
merged, at last! |
54 tasks
This was referenced Oct 21, 2022
clokep
pushed a commit
to clokep/matrix-spec
that referenced
this pull request
May 3, 2023
14 tasks
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
21 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered
Replaces #1849 along with #2674, #2675, and #2677
Fixes: matrix-org/matrix-spec#184
FCP proposal: #2676 (comment)
As the document says: this is intended to match the implementations currently in place in Synapse and Element-Web.