Add loose markdown linter #2796
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thib <[email protected]>
Signed-off-by: Thib <[email protected]>
Signed-off-by: Thib <[email protected]>
Deploying matrix-website with
|
| Latest commit: |
28e9a1a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://94629def.matrix-website.pages.dev |
| Branch Preview URL: | https://add-loose-markdown-linter.matrix-website.pages.dev |
Signed-off-by: Thib <[email protected]>
HarHarLinks
added
the
meta
Signed-off-by: Thib <[email protected]>
Signed-off-by: Thib <[email protected]>
HarHarLinks
reviewed
Jun 26, 2025
|
|
||
| [embed]https://www.youtube.com/watch?v=As-5vVdXhu0[/embed] | ||
| [embed]<https://www.youtube.com/watch?v=As-5vVdXhu0[/embed>] |
HarHarLinks
reviewed
Jun 26, 2025
| @@ -84,7 +84,7 @@ namespaces: | |||
| To test everything is working correctly, go ahead and explicitly create a room with the alias "#logged_test:localhost" and send a message into the room: the HS will relay the message to the AS by PUTing to /transactions/<tid> and you should see your AS print the event on the terminal. This will monitor any room which has an alias prefix of "#logged_", but it won't lazily create room aliases if they don't already exist. This means it will only log messages in the room you created before: #logged_test:localhost. Try joining the room "#logged_test2:localhost" without creating it, and it will fail. Let's fix that and add in lazy room creation: | |||
| <pre>@app.route("/rooms/<alias>") | |||
| def query_alias(alias): | |||
| alias_localpart = alias.split(":")[0][1:] | |||
| alias_localpart = alias.split[":"](0)[1:] | |||
Signed-off-by: Thib <[email protected]>
…disable them for now Signed-off-by: Thib <[email protected]>
HarHarLinks
reviewed
Jun 26, 2025
| reference-links-images: false | ||
| # table-pipe-style: | ||
| # style: consistent | ||
| table-column-coune: false |
There was a problem hiding this comment.
what is a "coune"? is this going over my head or supposed to be "count"? is there a reference for all the options?
|
Is it possible to add a check that we do internal links properly internally? |
Merged
|
How to handle this? |
|
How about escaping the link as inline code? |
I'm not 100% sure what would and what wouldn't be acceptable to e.g. in this case the SCT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
goals:
future ideas: