-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Show joystick calibration #13488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Show joystick calibration #13488
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the joystick calibration UI by adding real-time visualization of calibrated axis output values. The changes help users verify that calibration is applied correctly by showing how the joystick inputs are processed after calibration settings are applied.
- Added helper functions to apply clamping, mapping, and reversal logic to joystick inputs
- Updated axis value connections to use calibrated values instead of raw inputs
- Integrated calibration reversal settings into the real-time display
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Thansk for the suggestion Co-authored-by: Copilot <[email protected]>
|
Looks like you removed the 0:1 range for thrust? |
|
@Niki-dev12 Just making sure I"m not missing something here. The only change here is that the channel display bars respect the reversed attribute right? Other than that they work exactly the same? |
Before QML was showing raw joystick signal with a fixed formula, so any calibration changes (invert, min/max, center, deadzone, remap) applied in the controller layer did not affect what the QML drew. QGC was visualizing the pre-calibration values. |
The input range (0..1) is still assumed, but the polarity flipped compared to the old non negative thrust path. |
Show calibrated joystick axis output in calibration screen
Description
This update chnages the joystick calibration UI by displaying real-time calibrated axis output values for Roll, Pitch, Yaw, and Throttle during and after calibration.
It helps verify that calibration is applied correctly.
Key changes
Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.