chore: improve check tofu to be more self-contained #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I also ran a multi-directory test successfully here |
paulswartz
reviewed
Jan 2, 2026
| # Setup Cache Directory | ||
| if [[ ! -d "$TF_PLUGIN_CACHE_DIR" ]]; then | ||
| echo "Creating Tofu plugin cache directory at $TF_PLUGIN_CACHE_DIR" | ||
| mkdir -p "$TF_PLUGIN_CACHE_DIR" |
Member
There was a problem hiding this comment.
suggestion: mkdir -p already works like this (not erroring if the directory already exists) so you don't need to wrap it in an existence check.
Comment on lines
+91
to
92
| local start_time | ||
| start_time=$(date +%s) |
Member
There was a problem hiding this comment.
Suggested change
| local start_time | |
| start_time=$(date +%s) | |
| local start_time=$(date +%s) |
Comment on lines
+111
to
112
| local end_time | ||
| end_time=$(date +%s) |
Member
There was a problem hiding this comment.
Suggested change
| local end_time | |
| end_time=$(date +%s) | |
| local end_time=$(date +%s) |
| export TF_PLUGIN_CACHE_DIR="$TF_PLUGIN_CACHE_DIR" | ||
| } | ||
|
|
||
| function check_binary() { |
Member
There was a problem hiding this comment.
question: can you say more about the situation where this is needed?
| run_module_checks "${tf_dir}"; | ||
| done < <(get_terraform_root_modules) | ||
| # If CHANGED_DIRS env var is set (from CI), use it, otherwise scan all | ||
| if [[ -n "$CHANGED_DIRS" ]]; then |
Member
There was a problem hiding this comment.
question: this looks like it's another way to run a specific set of checks. is there a way to pass $CHANGED_DIRS as the arguments to this script rather than special-casing it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes a few updates to the
check-tofuaction, as recommended by @ianwestcott.I tested this successfully in a workflow run here
Asana task: https://app.asana.com/1/15492006741476/project/1113545750913664/task/1212628693483355?focus=true