chore: upgrade Elixir, Erlang, Phoenix #2864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this use case is now handled in the runtime config anyway
joshlarson
approved these changes
Jan 5, 2026
| [:sasl | extra_apps] | ||
| else | ||
| extra_apps | ||
| [:wx, :observer | extra_apps] |
Contributor
There was a problem hiding this comment.
Out of curiosity, what are these for?
| end) | ||
|
|
||
| assigns = assign(assigns, links: links) | ||
| assigns = Phoenix.Controller.assign(assigns, links: links) |
Contributor
There was a problem hiding this comment.
Non-blocking: Is this necessary?
| {Phoenix.PubSub, name: Dotcom.PubSub}, | ||
| Alerts.BusStopChangeSupervisor, | ||
| Alerts.CacheSupervisor | ||
| ] ++ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
erlang 28.0 → 28.2
elixir 1.18.4 → 1.19.4
Phoenix 1.8.1 → 1.8.3
I was mostly curious if I could get a more cooperative local dev environment which didn't crash on recompilation so often. I'm not sure if I achieved that, but at least we can keep up with our incremental upgrades.
Some corrections/improvements made along the way:
check_originhost is already set in runtime.exs and thus I didn't need any of the other code around configuring that:allow_indexingconfiguration was written before we had aruntime.exs. Using the runtime configuration file to set that value lets me clean up a lot of code!# hack to pull the STATIC_SCHEME variable out of the environmentalso came beforeruntime.exs, and also doesn't do anything useful as currently written. So I hypothesize we don't need that anymore