remove react-hook-form #1550
Merged
remove react-hook-form #1550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitalcora
approved these changes
Jan 5, 2026
Contributor
digitalcora
left a comment
digitalcora
left a comment
There was a problem hiding this comment.
Nice simplification of the tests, and of course I always like removing dependencies! One minor suggestion.
assets/js/ConfiguredHeadwaysForm.tsx
Outdated
| id="apply" | ||
| type="submit" | ||
| disabled={!isDirty || !isValid} | ||
| disabled={!isDirty || !isValid || !inEditMode} |
Contributor
There was a problem hiding this comment.
I got a little tied up trying to understand this and had to go refresh myself on De Morgan's law...
!A || !B || !C == !(A && B && C)
A more natural way to describe this might be "there are three conditions, and all must be true before you can submit". Putting this into code:
const canSubmit = inEditMode && isDirty && isValid
// ...
disabled={!canSubmit}Opinions on just the boolean transformation or extracting a variable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
react-hook-formin favor of explicit form state management for the headway values. This library was adding a fair bit of complexity and not providing much value given our simple use case. It was also exhibiting some inconsistent behavior while trying to upgrade the package.