feat: use full minecraft version to get pack_format #488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://discord.com/channels/900530660677156924/1447533823301521449/1447533823301521449 People are encountering issues with current mecha versions (which do not use full minecraft version), Should be high priority |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix #471 by creating a database of minecraft version in a resources folder (like what mecha does for command trees) and using it to get the pack_format.
Disadvantages :
This transform the two old classvar to properties, they act the same with an object of that class, but breaks few thing that were using the class itself.fixedThis PR comes with a PR for mecha with new command tree.This PR was originally #472, but remade here
PS: don't forget to squash merge this PR