fix[docs]: fix errors in docs/overview.md #490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the error where RGBA images in jupyter notebooks (like the `handle.image` example in `docs/overview.md`) show an error about not being able to save an RGBA image as JPEG.
- The default `pack.mcmeta` has changed, so a comparison that was probably intended to return True instead returned False. - Commit `5d003d3` replaced `Pack.content` with `Pack.all()`, but this doc was never updated to match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pack.mcmetahas changed, so a comparison that was probably intended to return True instead returned False.5d003d3replacedPack.contentwithPack.all(), but this doc was never updated to match.pillow, fixing the error message in thehandle.imageexample about RGBA images not being saveable as JPEG.