Restructure the OOJS test your skills navigation #40820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:Learn
bsmth
reviewed
Aug 21, 2025
There was a problem hiding this comment.
We could consider moving this into the parent
bsmth
approved these changes
Aug 21, 2025
There was a problem hiding this comment.
LGTM, thanks. One comment about the tree, like:
advanced_javascript_objects/test_your_skills
├── index.md
└── object-oriented_javascript
└── index.md
Where there's only one child, maybe we could move the content up like this:
advanced_javascript_objects/test_your_skills
└── index.md
Otherwise, good to go!
@bsmth this makes sense, however, I am currently thinking about adding some more skill tests to this module. Merging for now, but I'll move it like you said if I decide the other way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR restructures the Learning area Advanced OOJS module "test your skills" navigation, in the same way as #40503 did for the a11y module.
Motivation
Additional details
Related issues and pull requests