Skip to content

40778 color input value #41086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Sep 15, 2025
Merged

40778 color input value #41086

merged 24 commits into from
Sep 15, 2025

Conversation

dletorey
Copy link
Contributor

@dletorey dletorey commented Sep 10, 2025 •
edited
Loading

Description

  • Added pages for:
    • alpha attribute
    • colorspace attribute
  • Added these attributes to:
    • the attributes input table
    • the attribute list
  • On color input page:
    • updated the BCD data
    • updated the See Also list

Motivation

Related issues and pull requests

@dletorey dletorey requested review from a team as code owners September 10, 2025 09:44
@dletorey dletorey requested review from estelle and sideshowbarker and removed request for a team September 10, 2025 09:44
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs Content:WebAPI Web API docs labels Sep 10, 2025
@dletorey dletorey mentioned this pull request Sep 10, 2025
Merged
@github-actions github-actions bot added the size/m [PR only] 51-500 LoC changed label Sep 10, 2025
@dletorey dletorey requested review from bsmth and removed request for estelle September 10, 2025 09:45
@dletorey @github-actions
Update files/en-us/web/html/reference/attributes/alpha/index.md
992ac6b 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
dletorey and others added 2 commits September 10, 2025 10:45
@dletorey @github-actions
Update files/en-us/web/html/reference/attributes/colorspace/index.md
f8131c8 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@dletorey @github-actions
Update files/en-us/web/html/reference/attributes/colorspace/index.md
e4dfe88 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 10, 2025 •
edited
Loading

Preview URLs

Flaws (34)

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/HTML/Reference/Attributes
Title: HTML attribute reference
Flaw count: 34

  • broken_links:
    • Can't resolve /en-US/docs/Web/HTML/Reference/Attributes/alt
    • Can't resolve /en-US/docs/Web/HTML/Reference/Attributes/autoplay
    • Can't resolve /en-US/docs/Web/HTML/Reference/Attributes/cite
    • Can't resolve /en-US/docs/Web/HTML/Reference/Attributes/colspan
    • Can't resolve /en-US/docs/Web/HTML/Reference/Attributes/controls
    • and 29 more flaws omitted

(comment last updated: 2025-09-15 10:55:54)

This was referenced Sep 10, 2025
Merged
Closed
@sideshowbarker sideshowbarker removed their request for review September 10, 2025 10:44
@Josh-Cena
Copy link
Member

Josh-Cena commented Sep 10, 2025 •
edited
Loading

Hello, FYI we don't have an established convention yet, but it is an active discussion about what HTML/Reference/Attribute should contain: https://github.com/orgs/mdn/discussions/688. I think generally people agree that a page should only be created here in one of two cases: the attribute is shared between many elements, OR significant explanation/examples are required for its behavior (perhaps it is even an AND). I'm not sure either condition is met in this case (case in point: both of the pages you wrote are quite short). For these short pages, they don't add much beyond what's already present in the attributes DL on the element page, so creating another page adds close to zero value. This was why #40260 did not write these pages, and I believe there's really no reason to put in further effort beyond what's already in that PR.

bsmth
bsmth reviewed Sep 11, 2025
View reviewed changes
bsmth
bsmth reviewed Sep 11, 2025
View reviewed changes
@bsmth
Copy link
Member

bsmth commented Sep 15, 2025

Hello, FYI we don't have an established convention yet, but it is an active discussion about what HTML/Reference/Attribute should contain: https://github.com/orgs/mdn/discussions/688. I think generally people agree that a page should only be created here in one of two cases: the attribute is shared between many elements, OR significant explanation/examples are required for its behavior…

@dletorey I think this is a good point; details are worth mentioning here https://pr41086.review.mdn.allizom.net/en-US/docs/Web/HTML/Reference/Elements/input/color on <input type="color"/> but maybe the individual pages are not necessary in their current form.

@github-actions github-actions bot removed the Content:WebAPI Web API docs label Sep 15, 2025
@dletorey dletorey requested a review from bsmth September 15, 2025 10:54
bsmth
bsmth approved these changes Sep 15, 2025
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@dletorey dletorey merged commit baa785a into mdn:main Sep 15, 2025
8 checks passed
wbamberg added a commit to wbamberg/content that referenced this pull request Sep 15, 2025
@wbamberg
Merge remote-tracking branch 'upstream/main' into attacks-phishing
18cfefb 
* upstream/main: (32 commits)
  FF143 GPU import external texture experimental relnote (mdn#41126)
  added ff release note for nested pseudo-elements (mdn#41146)
  Add a page for SSRF attacks (mdn#41105)
  New CSSOM view API landing page, move CSS guides under (mdn#40547)
  40778 color input value (mdn#41086)
  Synchronize with BCD v7.1.5 (mdn#41116)
  Cross-reference `:target` and `::target-text` pages (mdn#41121)
  Fix content issues (mdn#41125)
  Make all JSON code syntactically valid (mdn#41120)
  Fix the link name with actual heading (mdn#41117)
  Associated listed form controls (mdn#41096)
  Mention `new Set()` accepts `undefined` (mdn#41106)
  chore: correct the `timeRange` function name (mdn#41107)
  Mention that custom elements constructors can't be directly called (mdn#41069)
  chore(deps): bump @mdn/fred from 1.3.2 to 1.4.0 (mdn#41111)
  Public-key cryptography glossary page: add headings and links (mdn#41092)
  Improve caret color demo contrast (mdn#41104)
  Fix supported algorithms for HKDF and PBKDF2 (mdn#41100)
  Update MongoDB example to async/await (driver v5+) (mdn#41102)
  Remove onload and DOMContentLoaded handlers (mdn#41079)
  ...
@dletorey dletorey deleted the 40778-color-input-value branch September 16, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@bsmth bsmth bsmth approved these changes

Assignees

No one assigned

Labels

Content:HTML Hypertext Markup Language docs size/m [PR only] 51-500 LoC changed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dletorey @Josh-Cena @bsmth