-
Notifications
You must be signed in to change notification settings - Fork 22.9k
New page on filing browser bugs #41187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
b22fd06
to
688b99e
Compare
I was taking a quick look to check if there's another place to add this info - haven't found one yet. Might be good to tag @chrisdavidmills since he's the most familiar with all the corners of the Learn area and may have a better suggestion. I'll come back with a more detailed review. In the meantime, what do you think about adding a "See also" to How browsers load websites to include a link to the new page? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Josh-Cena A few thoughts for you.
In terms of placement, this is quite reasonable, imo.
files/en-us/learn_web_development/howto/web_mechanics/file_browser_bugs/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/howto/web_mechanics/file_browser_bugs/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/howto/web_mechanics/file_browser_bugs/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/howto/web_mechanics/file_browser_bugs/index.md
Outdated
Show resolved
Hide resolved
Yeah, a lot of them are not really howtos, but I really wasn't sure where else to put them. A lot of them are old articles that have been around since the Learn area was first started. I just stashed them here for now, but we ought to figure out what to do. They are really "common questions", but I wanted to try to use the "Howtos" format as that is what we are doing in other topic areas. I'm wondering if we should add a "common questions" section to contain these alongside the "Howtos", or reformat them to be howtos, or something else. Some of them could probably even be deleted to save repetition or merged into other articles. |
Reordered the sections a bit. Reconciling browsers, docs, and spec is muddy waters because any of them could be incorrect, so this can be easily confusing😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Josh-Cena Nice work, this is looking much better. I've made a few more language suggestions, including adding a few H3s into the main section to break it up a bit, but this is comparatively minor stuff now that the structure is getting there.
files/en-us/learn_web_development/howto/web_mechanics/file_browser_bugs/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/howto/web_mechanics/file_browser_bugs/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/howto/web_mechanics/file_browser_bugs/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/howto/web_mechanics/file_browser_bugs/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/howto/web_mechanics/file_browser_bugs/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/howto/web_mechanics/file_browser_bugs/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/howto/web_mechanics/file_browser_bugs/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/howto/web_mechanics/file_browser_bugs/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/howto/web_mechanics/file_browser_bugs/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/howto/web_mechanics/file_browser_bugs/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Chris Mills <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for adding this page, Josh.
Thanks also to Chris for reviewing! I'm leaving a +1, but Chris may also want to take another look before merging.
files/en-us/learn_web_development/howto/web_mechanics/file_browser_bugs/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/howto/web_mechanics/file_browser_bugs/index.md
Outdated
Show resolved
Hide resolved
|
||
## Whose bug is it? | ||
|
||
Before filing a browser bug, you should make sure that the bug is real. It could be in one of four places: your code, the documentation, the browser, or the specification. Generally, the specification is the most credible source of all; browsers and documentation both follow the spec and can be wrong. As for your code...well, the quality depends on you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is what we're trying to say...added some connectors to build the flow.
I found the last sentence a bit snarky, I've tried to soften it a bit.
Before filing a browser bug, you should make sure that the bug is real. It could be in one of four places: your code, the documentation, the browser, or the specification. Generally, the specification is the most credible source of all; browsers and documentation both follow the spec and can be wrong. As for your code...well, the quality depends on you. | |
Before filing a browser bug, you should confirm that it's actually a bug in the browser. The problem could come from one of four places: your code, the documentation, the browser, or the specification. It's important to rule out the other possibilities before reporting a bug to the browser. Generally, specifications are the most credible source of all; browsers and documentation both follow specifications, but can still have mistakes. As for your code, it's always worth double-checking for logic and typos before assuming it's a browser bug. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's really meant to be a little snarky. The implication is "your code is the most likely to be incorrect of them all" :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess "before assuming it's a browser bug." retains a tiny bit of snark
files/en-us/learn_web_development/howto/web_mechanics/file_browser_bugs/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/howto/web_mechanics/file_browser_bugs/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/howto/web_mechanics/file_browser_bugs/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/howto/web_mechanics/file_browser_bugs/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/howto/web_mechanics/file_browser_bugs/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/howto/web_mechanics/file_browser_bugs/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/howto/web_mechanics/file_browser_bugs/index.md
Outdated
Show resolved
Hide resolved
...n-us/learn_web_development/getting_started/web_standards/how_browsers_load_websites/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/howto/web_mechanics/file_browser_bugs/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/howto/web_mechanics/file_browser_bugs/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Dipika Bhattacharya <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more minor comments, but I'll approve this now. I don't think I need to look at it again. Nice work, @Josh-Cena!
...n-us/learn_web_development/getting_started/web_standards/how_browsers_load_websites/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/howto/web_mechanics/file_browser_bugs/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/howto/web_mechanics/file_browser_bugs/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/howto/web_mechanics/file_browser_bugs/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Chris Mills <[email protected]>
files/en-us/learn_web_development/howto/web_mechanics/file_browser_bugs/index.md
Outdated
Show resolved
Hide resolved
…wser_bugs/index.md
Fix #28312. This has the nice effect of getting rid of "how-to" guides in ARIA, because currently this one is extremely thin and isn't even a guide. The placement of the doc is tentative, because I can't find a better place for general web stuff.