-
Notifications
You must be signed in to change notification settings - Fork 22.9k
[Experiment]: Add CSS layout additional tutorials links to learnsidebar #41196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Experiment]: Add CSS layout additional tutorials links to learnsidebar #41196
Conversation
There isn't a chance we could just incorporate them into the normal flow instead of stashing them away? No strong opinions, this does solve the reported problem. |
They were in the normal flow, but during my big audit and restructuring of the Learn area, these were the articles that I deemed potentially useful, but not suitable for the normal flow. CSS multi-col is not an essential layout technique that you should advise all beginners to learn, in the same way that flexbox or grid is, for example. |
details: closed | ||
children: | ||
- /Learn_web_development/Core/CSS_layout/Multiple-column_Layout | ||
- /Learn_web_development/Core/CSS_layout/Practical_positioning_examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Positioning one is still okay for "normal flow", IMO. Would you consider the others "legacy" techniques instead of "additional"?
Overall, I think it's alright to have them on the same level as the other guides, but maybe down lower in the sidebar (more niche) with their status / context in the article intro.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Positioning one is still okay for "normal flow", IMO. Would you consider the others "legacy" techniques instead of "additional"?
I'm not sure what you mean by "Positioning one is still okay for "normal flow"". Can you rephrase?
They are not all legacy techniques.
Overall, I think it's alright to have them on the same level as the other guides, but maybe down lower in the sidebar (more niche) with their status / context in the article intro.
I disagree. I think having them at the same level in the nav will make people think they are part of the normal flow, and surprise them when they don't get to them via prev/next.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree. I think having them at the same level in the nav will make people think they are part of the normal flow, and surprise them when they don't get to them via prev/next.
I forgot about prev/next continuity expectation -> you have the best feel for that in terms of the pathway, so deferring to you on that.
Positioning one is still okay for "normal flow" Can you rephrase?
I thought this guide has some good info, it could be useful to have it up with the others, IMO, but up to you 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for adding these docs into the sidebars, tnx
Yeah also a +1 for me |
Description
There are still several Learn articles not linked from the learnsidebar. The ones we want to keep should really be linked in some way. This PR provides an experimental suggestion of what we could do in each case — an "Additional tutorials" subsection at the end of each module sidebar subsection.
Motivation
Additional details
Related issues and pull requests