improve: refactor APNG loader to use libpng-based implementation #1315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I don't know if my baseline is outdated, but I'm getting this compilation error, vs community 2022 solution 1>D:\github\otclient.readme\src\framework\graphics\apng_png.hpp(164,71): warning C4003: not enough arguments for function-like macro invocation 'max'
1>(compiling source file 'otclient/x64/OpenGL/unity_QAHRA73EM9MJH98D.cpp')
1>D:\github\otclient.readme\src\framework\graphics\apng_png.hpp(164,71): error C2589: '(': illegal token on right side of '::'
1>(compiling source file 'otclient/x64/OpenGL/unity_QAHRA73EM9MJH98D.cpp')
1>D:\github\otclient.readme\src\framework\graphics\apng_png.hpp(164,40): error C2062: type 'unknown-type' unexpected
1>(compiling source file 'otclient/x64/OpenGL/unity_QAHRA73EM9MJH98D.cpp')
1>D:\github\otclient.readme\src\framework\graphics\apng_png.hpp(164,40): error C2144: syntax error: 'unknown-type' should be preceded by '('
1>(compiling source file 'otclient/x64/OpenGL/unity_QAHRA73EM9MJH98D.cpp')
1>D:\github\otclient.readme\src\framework\graphics\apng_png.hpp(164,77): error C2059: syntax error: ')'
1>(compiling source file 'otclient/x64/OpenGL/unity_QAHRA73EM9MJH98D.cpp')
1>D:\github\otclient.readme\src\framework\graphics\apng_png.hpp(263,52): warning C4003: not enough arguments for function-like macro invocation 'max'
1>(compiling source file 'otclient/x64/OpenGL/unity_QAHRA73EM9MJH98D.cpp')
1>D:\github\otclient.readme\src\framework\graphics\apng_png.hpp(263,52): error C2589: '(': illegal token on right side of '::'
1>(compiling source file 'otclient/x64/OpenGL/unity_QAHRA73EM9MJH98D.cpp')
1>D:\github\otclient.readme\src\framework\graphics\apng_png.hpp(263,23): error C2062: type 'unknown-type' unexpected
1>(compiling source file 'otclient/x64/OpenGL/unity_QAHRA73EM9MJH98D.cpp')
1>D:\github\otclient.readme\src\framework\graphics\apng_png.hpp(263,71): error C2059: syntax error: ')'
1>(compiling source file 'otclient/x64/OpenGL/unity_QAHRA73EM9MJH98D.cpp')posible fix: ( )- std::min<uint32_t>(milliseconds, std::numeric_limits<uint16_t>::max()));
+ std::min<uint32_t>(milliseconds, (std::numeric_limits<uint16_t>::max)()));- totalFrames > std::numeric_limits<size_t>::max() / frameStride)
+ totalFrames > (std::numeric_limits<size_t>::max)() / frameStride) |
majestyotbr
changed the title
libergod
force-pushed
the
use-libpng
branch
2 times, most recently
from
35bc000 to
e5a42be
Compare
|
|
This PR is stale because it has been open 45 days with no activity. |
Replaces the custom APNG loading and saving logic in apngloader.cpp with a new implementation based on libpng, moved to apng_png.hpp. Updates CMakeLists.txt to require PNG, and ensures libpng is built with APNG support. This change modernizes and simplifies APNG handling, improving maintainability and leveraging standard library support.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the custom APNG loading and saving logic in apngloader.cpp with a new implementation based on libpng, moved to apng_png.hpp. Updates CMakeLists.txt to require PNG, and ensures libpng is built with APNG support. This change modernizes and simplifies APNG handling, improving maintainability and leveraging standard library support.