-
Notifications
You must be signed in to change notification settings - Fork 105
Update repository config for v2 #787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds v1.x to GitHub workflow branch triggers, updates composer authors and script formatting, and changes exception __toString message checks to use non-empty string comparisons across three exception classes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal). Please share your feedback with us on this Discord post. Pre-merge checks (2 passed, 1 warning)❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
d44deaa
to
5cd3792
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (4)
.github/workflows/tests.yml (1)
75-75
: Avoid using the drifting Docker tag 'latest' for CI stabilityPin the Meilisearch service image to a major or exact version to reduce flaky failures when the upstream image changes.
Apply:
- image: getmeili/meilisearch:latest + image: getmeili/meilisearch:v1 # or pin an exact version once decided, e.g. v1.11.0src/Exceptions/InvalidResponseBodyException.php (1)
28-30
: More precise non-empty check for message — good; consider trimming whitespaceCurrent change preserves messages like "0". To also skip whitespace-only messages:
- if ('' !== $this->message) { + if ('' !== trim((string) $this->message)) { $base .= ' - Message: '.$this->message; }src/Exceptions/TimeOutException.php (1)
23-27
: Consistent style with other exceptions and skip whitespace-only messagesMinor clean-up: mirror the pattern used elsewhere and reduce branching.
- if ('' !== $this->message) { - return $base.' - Message: '.$this->message; - } else { - return $base; - } + if ('' !== trim((string) $this->message)) { + $base .= ' - Message: '.$this->message; + } + return $base;src/Exceptions/ApiException.php (1)
36-38
: Non-empty check — good; consider trimming to ignore whitespace-only valuesKeeps "0" while avoiding null-related pitfalls. Optional trim for parity with other suggestions:
- if ('' !== $this->message) { + if ('' !== trim((string) $this->message)) { $base .= ' - Message: '.$this->message; }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
.github/workflows/release-drafter.yml
(1 hunks).github/workflows/tests.yml
(1 hunks)composer.json
(2 hunks)src/Exceptions/ApiException.php
(1 hunks)src/Exceptions/InvalidResponseBodyException.php
(1 hunks)src/Exceptions/TimeOutException.php
(1 hunks)
🔇 Additional comments (4)
.github/workflows/tests.yml (1)
12-12
: v1.x push trigger — LGTMThis will run CI on maintenance updates to v1.x. Matches the PR’s intent.
.github/workflows/release-drafter.yml (1)
7-7
: Add v1.x to Release Drafter triggers — LGTMEnsure RELEASE_DRAFTER_TOKEN is available to workflows on the v1.x branch protection settings.
composer.json (2)
16-30
: Authors metadata update — LGTMAccurate credits; no functional impact.
73-75
: Test script reformat — LGTMPure formatting; command unchanged.
* Update repository config for v2 (#787) * Update CI workflows * Update contributors * Update empty string comparison * lint * Cast federation payload explicilty to an object (#757) * Cast federation payload explicilty to an object * Add unit test for multisearch federation array to object casting --------- Co-authored-by: Thijs Kuilman <[email protected]> Co-authored-by: Laurent Cazanove <[email protected]> --------- Co-authored-by: Tomas Norkūnas <[email protected]> Co-authored-by: Thijs Kuilman <[email protected]>
Pull Request
Preliminary work for #761
v1.x
branchcomposer.json
🥳PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!
Summary by CodeRabbit
Bug Fixes
Chores