ooaklee/Add-mattermost-notifier-integration #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 30, 2022 01:34
- Added logic to config to map mattermost notifier - Added packages needed to send a message with mattermost notifier - Added client for interacting with mattermost - Added mattermost notifier case - Added mattermost notifier to README
- Updated env vars name (slack > mattermost)
- Enabled Markdown in payload - Added screenshot for Mattermost message
ooaklee
requested review from
KeisukeYamashita,
babarot,
drlau,
dtan4 and
micnncim
as code owners
ooaklee
pushed a commit
to ooaklee/tfnotify
that referenced
this pull request
Oct 30, 2022
…the ChatPostMessage errors as we expect
ooaklee
pushed a commit
to ooaklee/tfnotify
that referenced
this pull request
Nov 1, 2022
drlau
approved these changes
Dec 9, 2022
Contributor
drlau
left a comment
drlau
left a comment
There was a problem hiding this comment.
LGTM! Thanks for your contribution 😄
drlau
suggested changes
Dec 9, 2022
Contributor
drlau
left a comment
drlau
left a comment
There was a problem hiding this comment.
actually sorry one thing, can you resolve the conflicts? it's just dependencies
ooaklee
requested review from
drlau
and removed request for
KeisukeYamashita,
babarot,
dtan4 and
micnncim
Author
|
Hey @drlau, sorry about the delay. The conflicts have been resolved 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Mattermostas a notifierWHY
Many people/ small teams are migrating over to
Mattermostwith the recent changes toSlack. With this update, they'll be able to migrate this awesome tool with them and continue to receive their updates.