Skip to content

Conversation

DaneEvans
Copy link
Collaborator

@DaneEvans DaneEvans commented Aug 15, 2025

Add response for metadata request.

Working, The only question is if it's worth this amount of overhead.
Will run spotless and detekt on it after initial review.

@github-actions github-actions bot added the enhancement New feature or request label Aug 15, 2025
@DaneEvans DaneEvans changed the title Feat/#2696 req metadata Feat/#2696 response to request metadata Aug 16, 2025
Copy link
Collaborator

@jamesarich jamesarich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that this opens the door for other potential calls w/ callbacks that we can surface. I do wonder if the reaction/dialog should happen at a higher level, there's potential for a metadata request from the node list longpress menu too

@jamesarich
Copy link
Collaborator

playing w/ this just gave me flashbacks from callback hell - i'm wondering if there's a way to tackle this in a more reactive/unidirectionally flowing way

@DaneEvans
Copy link
Collaborator Author

I was wondering if we just set a flag - expecting a callback from (traceroute, nodenum)
And if we get a matching packet within 60 seconds, we do the popup then.

It wouldn't block UI, it'll reset fine if it doesn't get a response, it's more generalised etc

@jamesarich jamesarich closed this Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants