-
Notifications
You must be signed in to change notification settings - Fork 199
Connection robustness improvements #813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
fb8dac1
Clear heartbeat and queue when disconnected
bergie 0bf3555
Give clearer error in case configure fails due to a lost connection. …
bergie 5b503e1
If the queue processing error is due to a lost connection, throw it i…
bergie 226dcce
In case we send a disconnection event we don't need to also throw
bergie cf488d9
Catch heartbeat errors
bergie dadcf13
Also handle invalid state errors
bergie f3089a4
Handle socket timeouts
bergie d3b171d
Log heartbeat failures
bergie d6cfd14
Make linter happy
bergie bdfb8c5
Transform stream being a singleton prevented reconnection attempts
bergie 4eb7dc7
Adapt tests to not using singleton
bergie c99bade
Aborting already ends the connection
bergie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,18 @@ | ||
/** | ||
* Pads packets with appropriate framing information before writing to the output stream. | ||
*/ | ||
export const toDeviceStream: TransformStream<Uint8Array, Uint8Array> = | ||
new TransformStream<Uint8Array, Uint8Array>({ | ||
transform(chunk: Uint8Array, controller): void { | ||
const bufLen = chunk.length; | ||
const header = new Uint8Array([ | ||
0x94, | ||
0xc3, | ||
(bufLen >> 8) & 0xff, | ||
bufLen & 0xff, | ||
]); | ||
controller.enqueue(new Uint8Array([...header, ...chunk])); | ||
}, | ||
}); | ||
export const toDeviceStream: () => TransformStream<Uint8Array, Uint8Array> = | ||
() => { | ||
return new TransformStream<Uint8Array, Uint8Array>({ | ||
transform(chunk: Uint8Array, controller): void { | ||
const bufLen = chunk.length; | ||
const header = new Uint8Array([ | ||
0x94, | ||
0xc3, | ||
(bufLen >> 8) & 0xff, | ||
bufLen & 0xff, | ||
]); | ||
controller.enqueue(new Uint8Array([...header, ...chunk])); | ||
}, | ||
}); | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll fix the lint rule for this, to be explicit we should return undefined as that is what an empty return does