-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
cuda: Add support for sbsa-linux target #15002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small implementation nit, otherwise that part looks good.
It would be great to have a test for this as you noted. I'm not sure what our aarch64 CI situation is like these days.
bf2ce85
to
24d633a
Compare
Hey @dcbaker ! Thanks for the review. Have you thought about it, do you have any hints ? |
Eli knows a lot more about how the CI infrastructure works to be honest, and I'd be inclined to defer to his judgement on what we should do there. I'm happy with the implementation at this point, so I'm fine with merging this now and figuring out CI later, let's see what Eli says. |
@MaxandreOgeret can you rebase to clean CI? |
55f464b
to
24d633a
Compare
24d633a
to
1afb6d5
Compare
Should be good now |
#fix #14981
It adds a new function in the cuda target:
_detect_target_path
.And it will search the SBSA target path correctly on
aarch64
machines.Same logic as https://github.com/NVIDIA/cuda-samples/blob/3f1c50965017932fc81e6d94a3fc9e04c105b312/cmake/toolchains/toolchain-aarch64-linux.cmake#L18
Todo: