Skip to content

c-ares: update from 1.34.5 to 1.34.6 #2555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bgilbert merged 1 commit into from
Dec 11, 2025
Merged

c-ares: update from 1.34.5 to 1.34.6 #2555

bgilbert merged 1 commit into from
Dec 11, 2025

Conversation

@bgilbert
Copy link
Collaborator

@bgilbert bgilbert commented Dec 10, 2025

No description provided.

neheb
neheb reviewed Dec 10, 2025
View reviewed changes
neheb
neheb reviewed Dec 10, 2025
View reviewed changes
subprojects/packagefiles/c-ares/meson.build
'HAVE_KQUEUE': cc.has_header_symbol('sys/event.h', 'kqueue'),
'HAVE_EPOLL': cc.has_header_symbol('sys/epoll.h', 'epoll_create1'),
'TIME_WITH_SYS_TIME': (cc.has_header('sys/time.h') and cc.has_header('time.h')),
'TIME_WITH_SYS_TIME': (
Copy link
Collaborator

@neheb neheb Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this check correct?

Copy link
Collaborator Author

@bgilbert bgilbert Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what upstream has.

@neheb
Copy link
Collaborator

neheb commented Dec 10, 2025 •
edited
Loading 

c-ares| Header "sys/event.h" has symbol "kqueue" : NO

I wonder how cursed it would be to implement libkqueue support.

edit: very looks like

#  ifdef HAVE_PIPE
ares_event_t *ares_pipeevent_create(ares_event_thread_t *e);
#  endif

#  ifdef HAVE_POLL
extern const ares_event_sys_t ares_evsys_poll;
#  endif

#  ifdef HAVE_KQUEUE
extern const ares_event_sys_t ares_evsys_kqueue;
#  endif

#  ifdef HAVE_EPOLL
extern const ares_event_sys_t ares_evsys_epoll;
#  endif

#  ifdef _WIN32
extern const ares_event_sys_t ares_evsys_win32;
#  endif

those ifs should probably be elif.

@bgilbert bgilbert merged commit 31b8bfc into mesonbuild:master Dec 11, 2025
20 checks passed
@bgilbert bgilbert deleted the c-ares branch December 11, 2025 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neheb neheb neheb left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bgilbert @neheb