test PR for release 0.9 #1040
Draft
test PR for release 0.9 #1040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Dan-Flores
force-pushed
the
python314_on_ci
branch
from
abffb4a to
6805b52
Compare
Dan-Flores
changed the title
NicolasHug
reviewed
Nov 26, 2025
|
|
||
| jobs: | ||
| generate-matrix: | ||
| uses: pytorch/test-infra/.github/workflows/generate_binary_build_matrix.yml@main |
Contributor
There was a problem hiding this comment.
Make sure to rely on the release/2.9 branch of test-infra for all these yaml files. You'll also need to update test-infra-ref: main.
NicolasHug
reviewed
Nov 26, 2025
|
|
||
| [build-system] | ||
| requires = ["setuptools>=61.0"] | ||
| requires = ["setuptools>=69.0"] |
Contributor
There was a problem hiding this comment.
were the changes above needed? I'm surprise we don't need them in main?
Contributor
Author
There was a problem hiding this comment.
The license-files changes were needed to resolve this error on python 3.14. On review, I am not certain that requires a newer version of setuptools, though.
Contributor
There was a problem hiding this comment.
This is fishy (and sounds like a regression). We established the license-files = ["LICENSE"] way in #789
This is either a bug in setuptools, or we're doing something wrong here.
Dan-Flores
force-pushed
the
python314_on_ci
branch
from
8669861 to
92b1572
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.