Update Video Encoder and tests for 6 container formats #913
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the round trip test in test_ops.py to support 6 common video container formats with absolute tolerance
2
in the best case, and55
in the worst case.Additional changes are made to align with the design in #907:
These are the codecs and pixel formats used by default:
mp4:
Using codec: libx264
pixel format: gbrp -> yuv444p
avi:
Using codec: mpeg4
pixel format: gbrp -> yuv420p
matroska (mkv):
Using codec: libx264
pixel format: gbrp -> yuv444p
webm:
Using codec: libvpx-vp9
pixel format: gbrp -> gbrp
flv:
Using codec: flv
pixel format: gbrp -> yuv420p