Skip to content

Make it more obvious old sampler is deprecated #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 1, 2025
Merged

Make it more obvious old sampler is deprecated #916

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb5c915
Make it more obvious old sampler is deprecated
scotts Oct 1, 2025
59b87a8
Indicate deprecation in comment
scotts Oct 1, 2025
62ff3ab
Trigger new CI
scotts Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/torchcodec/_samplers/video_clip_sampler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ class IndexBasedSamplerArgs(SamplerArgs):
sample_step: int = 1


class VideoClipSampler(nn.Module):
class DEPRECATED_VideoClipSampler(nn.Module):
"""
VideoClipSampler will do video clip sampling with given video args and sampler args.
The video args contains video related information, frames_per_clip, dimensions etc.
Expand Down
4 changes: 2 additions & 2 deletions test/test_video_clip_sampler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@
import pytest
import torch
from torchcodec._samplers import (
DEPRECATED_VideoClipSampler,
IndexBasedSamplerArgs,
TimeBasedSamplerArgs,
VideoArgs,
VideoClipSampler,
)

from .utils import NASA_VIDEO
Expand All @@ -34,7 +34,7 @@ def test_sampler(sampler_args):
torch.manual_seed(0)
desired_width, desired_height = 320, 240
video_args = VideoArgs(desired_width=desired_width, desired_height=desired_height)
sampler = VideoClipSampler(video_args, sampler_args)
sampler = DEPRECATED_VideoClipSampler(video_args, sampler_args)
clips = sampler(NASA_VIDEO.to_tensor())
assert len(clips) == sampler_args.clips_per_video
clip = clips[0]
Expand Down
Loading