Add to_file_like support for VideoEncoder #958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Dan-Flores
changed the title
Dan-Flores
changed the title
Dan-Flores
force-pushed
the
video_to_filelike
branch
from
3e97d89 to
981a27e
Compare
Dan-Flores
force-pushed
the
video_to_filelike
branch
from
981a27e to
733022c
Compare
|
Addressed feedback from 3e97d89:
|
NicolasHug
approved these changes
Oct 20, 2025
test/test_ops.py
Outdated
| assert psnr(s_frame, rt_frame) > 30 | ||
| assert_close(s_frame, rt_frame, atol=atol, rtol=0) | ||
|
|
||
| @pytest.mark.slow |
There was a problem hiding this comment.
QQ was the whole test slow or is it just webm?
There was a problem hiding this comment.
Thanks for catching this, I should have deleted it after adding pytest.param("webm", marks=pytest.mark.slow).
NicolasHug
pushed a commit
to NicolasHug/torchcodec
that referenced
this pull request
Oct 27, 2025
Co-authored-by: Daniel Flores <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables encoding a video to file_like, similar to the
AudioEncoder. TheVideoEncoderconstructor accept anAVIOContextHolderand fileformat. It is instantiated withAVIOFileLikeContext.Testing:
test_video_encoder_round_tripandtest_against_to_fileare updated to testto_file_likemethod.test_to_file_like_custom_file_object,test_to_file_like_real_file,test_to_file_like_bad_methodstests are added.